Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WasbPrefixSensorAsync #1437

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

pankajkoti
Copy link
Collaborator

@pankajkoti pankajkoti commented Jan 19, 2024

Deprecate WasbPrefixSensorAsync and proxy it to its Airflow
OSS provider's counterpart

closes: #1412

setup.cfg Outdated Show resolved Hide resolved
@pankajkoti
Copy link
Collaborator Author

I have kept the PR in draft mode as it depends on apache/airflow#36806 and needs to wait for the OSS provider release including this PR.

@pankajkoti pankajkoti force-pushed the 1412-deprecate-WasbPrefixSensorAsync branch 4 times, most recently from 82b9cec to 0480fe6 Compare January 22, 2024 10:02
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7dfe99) 98.28% compared to head (8acabc1) 98.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%     
==========================================
  Files          91       91              
  Lines        4674     4662      -12     
==========================================
- Hits         4594     4582      -12     
  Misses         80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti pankajkoti marked this pull request as ready for review January 23, 2024 12:57
@pankajkoti pankajkoti marked this pull request as draft January 23, 2024 12:57
@pankajkoti
Copy link
Collaborator Author

The implementation work is complete here, but it's waiting for OSS provider release

@pankajkoti pankajkoti force-pushed the 1412-deprecate-WasbPrefixSensorAsync branch 2 times, most recently from bbe46e6 to 6ac4aba Compare January 31, 2024 07:58
@pankajkoti
Copy link
Collaborator Author

Verified with RC 9.0.0 that the DAG enters deferral and then succeeds

Screenshot 2024-01-31 at 1 47 19 PM Screenshot 2024-01-31 at 1 48 39 PM

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Copy link
Contributor

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankajkoti pankajkoti force-pushed the 1412-deprecate-WasbPrefixSensorAsync branch from 441ea60 to 8acabc1 Compare February 4, 2024 10:47
@pankajkoti pankajkoti marked this pull request as ready for review February 4, 2024 11:03
@pankajkoti pankajkoti merged commit f6d09ad into main Feb 4, 2024
11 checks passed
@pankajkoti pankajkoti deleted the 1412-deprecate-WasbPrefixSensorAsync branch February 4, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate microsoft async provider
2 participants