-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate BatchSensorAsync #1391
Conversation
632bec8
to
595df7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
- Coverage 98.57% 98.56% -0.02%
==========================================
Files 91 91
Lines 5460 5421 -39
==========================================
- Hits 5382 5343 -39
Misses 78 78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the integration DAGs that might be using this class, are we planning to remove them at a later point of time?
Please add description about why you are doing this change |
Yes, I think we should keep it for a while and remove it after we deprecate the whole repo.
Sure. let me reformat and reword it to make it easier to read. |
What's changed
Deprecate
BatchSensorAsync
and fallback toBatchSensor
withdeferrable=True
Why this change
The logic of
BatchSensorAsync
bas been contributed back to OSS airflow as part ofBatchSensor
BatchSensorAsync
astronomer-providers/astronomer/providers/amazon/aws/sensors/batch.py
Lines 46 to 68 in b5a9417
BatchSensor
https://github.com/apache/airflow/blob/999b70178a1f5d891fd2c88af4831a4ba4c2cbc9/airflow/providers/amazon/aws/sensors/batch.py#L98-L133