-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate S3KeysUnchangedSensorAsync #1392
Conversation
38d2a89
to
841a514
Compare
40f2573
to
ce595c6
Compare
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
- Coverage 98.57% 98.55% -0.02%
==========================================
Files 91 91
Lines 5460 5416 -44
==========================================
- Hits 5382 5338 -44
Misses 78 78 ☔ View full report in Codecov by Sentry. |
This PR is breaking our integration DAGs , @Lee-W to take a look |
It maybe an issue with OSS sensor, will leave it to Wei to check once. If it’s an upstream issue, I would suggest reverting this PR for the time being until a new OSS amazon provider including the fix is released. |
What's changed
Deprecate
S3KeysUnchangedSensorAsync
and fallback toS3KeysUnchangedSensor
withdeferrable=True
Why this change
The logic of
S3KeysUnchangedSensorAsync
has been contributed back to OSS airflow as part ofS3KeysUnchangedSensor
S3KeysUnchangedSensorAsync
astronomer-providers/astronomer/providers/amazon/aws/sensors/s3.py
Lines 195 to 223 in b5a9417
S3KeysUnchangedSensor
https://github.com/apache/airflow/blob/999b70178a1f5d891fd2c88af4831a4ba4c2cbc9/airflow/providers/amazon/aws/sensors/s3.py#L340-L374