-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate EmrContainerOperatorAsync #1393
Conversation
a8b5262
to
520dc28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
- Coverage 98.53% 98.40% -0.13%
==========================================
Files 91 91
Lines 5320 5268 -52
==========================================
- Hits 5242 5184 -58
- Misses 78 84 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor inline corrections to be addressed please before merging.
422d119
to
e021c33
Compare
e021c33
to
67b4326
Compare
67b4326
to
6671a06
Compare
* feat(amazon): deprecate EmrContainerOperatorAsync * feat(amazon): remove EmrContainerOperatorTrigger
* feat(amazon): deprecate EmrContainerOperatorAsync * feat(amazon): remove EmrContainerOperatorTrigger
* feat(amazon): deprecate EmrContainerOperatorAsync * feat(amazon): remove EmrContainerOperatorTrigger
What's changed
Deprecate
EmrContainerOperatorAsync
and fallback toEmrContainerOperator
withdeferrable=True
Why this change
The logic of
EmrContainerOperatorAsync
has been contributed back to OSS airflow as part ofEmrContainerOperator
EmrContainerOperatorAsync
astronomer-providers/astronomer/providers/amazon/aws/sensors/emr.py
Lines 38 to 65 in b5a9417
EmrContainerOperator
https://github.com/apache/airflow/blob/999b70178a1f5d891fd2c88af4831a4ba4c2cbc9/airflow/providers/amazon/aws/sensors/emr.py#L318-L346