Deprecate SnowflakeSqlApiOperatorAsync #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
phanikumv,
pankajastro,
pankajkoti,
Lee-W,
sunank200 and
utkarsharma2
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 98.22% 98.20% -0.02%
==========================================
Files 91 91
Lines 4733 4684 -49
==========================================
- Hits 4649 4600 -49
Misses 84 84 ☔ View full report in Codecov by Sentry. |
Lee-W
reviewed
Jan 23, 2024
vatsrahul1001
force-pushed
the
deprecate-SnowflakeSqlApiOperator
branch
from
76a0574 to
3acabbc
Compare
pankajkoti
reviewed
Jan 23, 2024
…omer/Astronomer-providers into deprecate-SnowflakeSqlApiOperator taking latest
adding warning |
2 tasks
|
Verified running a DAG locally with these changes that it enters deferred state and then succeeds 
|
Lee-W
reviewed
Jan 29, 2024
| from airflow.exceptions import AirflowException | ||
|
|
||
| from snowflake.connector import SnowflakeConnection | ||
| from snowflake.connector.constants import QueryStatus | ||
|
|
||
| try: | ||
| from airflow.providers.snowflake.operators.snowflake import SnowflakeOperator | ||
| from airflow.providers.snowflake.operators.snowflake import SnowflakeOperator, SnowflakeSqlApiOperator |
There was a problem hiding this comment.
I think we'll need to move this SnowflakeSqlApiOperator import outside of this block
There was a problem hiding this comment.
I think we can remove SnowflakeOperator here. We've update our snowflake provider version
Lee-W
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
SnowflakeSqlApiOperatorAsyncand fallback to its Airflow OSS provider's counterpartSnowflakeSqlApiOperatorwithdeferrable=Truecloses: #1415