Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RedshiftDataOperatorAsync, RedshiftClusterSensorAsync, S3KeySensorAsync, BatchOperatorAsync, SageMakerProcessingOperatorAsync, SageMakerTransformOperatorAsync #1455

Merged
merged 21 commits into from
Jan 29, 2024

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Jan 24, 2024

Deprecate RedshiftDataOperatorAsync, RedshiftClusterSensorAsync, S3KeySensorAsync, BatchOperatorAsync, SageMakerProcessingOperatorAsync, SageMakerTransformOperatorAsync and proxy them to their Airflow OSS provider's counterpart

@Lee-W Lee-W mentioned this pull request Jan 24, 2024
19 tasks
@Lee-W Lee-W force-pushed the deprecate-multiple-amazon-operators branch from 8f1447f to 1141103 Compare January 24, 2024 06:04
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ae5cb97) 98.28% compared to head (0fe7821) 98.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
...r/providers/amazon/aws/sensors/redshift_cluster.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
- Coverage   98.28%   98.22%   -0.06%     
==========================================
  Files          91       91              
  Lines        5076     4966     -110     
==========================================
- Hits         4989     4878     -111     
- Misses         87       88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 24, 2024

BatchOperatorAsync

image

@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 24, 2024

S3KeySensorAsync
image

@Lee-W Lee-W changed the title Deprecate multiple amazon operators Deprecate RedshiftDataOperatorAsync, RedshiftSQLOperatorAsync, RedshiftClusterSensorAsync, S3KeySensorAsync, BatchOperatorAsync, SageMakerProcessingOperatorAsync, SageMakerTransformOperatorAsync Jan 24, 2024
@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 24, 2024

SageMakerProcessingOperatorAsync, SageMakerTransformOperatorAsync

image

@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 24, 2024

RedshiftDataOperatorAsync

image

@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 24, 2024

RedshiftClusterSensorAsync

image

@Lee-W Lee-W force-pushed the deprecate-multiple-amazon-operators branch from b17c0dd to 26782c5 Compare January 24, 2024 10:13
@Lee-W Lee-W changed the title Deprecate RedshiftDataOperatorAsync, RedshiftSQLOperatorAsync, RedshiftClusterSensorAsync, S3KeySensorAsync, BatchOperatorAsync, SageMakerProcessingOperatorAsync, SageMakerTransformOperatorAsync Deprecate RedshiftDataOperatorAsync, RedshiftClusterSensorAsync, S3KeySensorAsync, BatchOperatorAsync, SageMakerProcessingOperatorAsync, SageMakerTransformOperatorAsync Jan 24, 2024
@Lee-W Lee-W marked this pull request as ready for review January 24, 2024 10:21
astronomer/providers/amazon/aws/operators/redshift_data.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@Lee-W Lee-W force-pushed the deprecate-multiple-amazon-operators branch from 079ffae to 19714a8 Compare January 25, 2024 10:47
@Lee-W Lee-W force-pushed the deprecate-multiple-amazon-operators branch from 19714a8 to ae03f35 Compare January 25, 2024 10:53
@Lee-W Lee-W requested a review from pankajastro January 29, 2024 06:57
astronomer/providers/amazon/aws/hooks/sagemaker.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/hooks/sagemaker.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/operators/batch.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/operators/redshift_data.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
astronomer/providers/amazon/aws/sensors/s3.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once above review comments are addressed.

@Lee-W Lee-W merged commit 52063a4 into main Jan 29, 2024
11 checks passed
@Lee-W Lee-W deleted the deprecate-multiple-amazon-operators branch January 29, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants