Deprecate SageMakerTrainingOperatorAsync #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
pankajkoti
reviewed
Jan 30, 2024
Lee-W
force-pushed
the
deprecate-SageMakerTrainingOperatorAsync
branch
from
534951a to
aa734a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 98.27% 98.24% -0.04%
==========================================
Files 91 91
Lines 4648 4609 -39
==========================================
- Hits 4568 4528 -40
- Misses 80 81 +1 ☔ View full report in Codecov by Sentry. |
Lee-W
force-pushed
the
deprecate-SageMakerTrainingOperatorAsync
branch
from
aa734a8 to
10a3c8f
Compare
pankajastro
reviewed
Feb 9, 2024
| if event and event["status"] == "error": | ||
| raise AirflowException(event["message"]) | ||
| raise AirflowException("No event received in trigger callback") | ||
| super().__init__(deferrable=True, **kwargs) |
There was a problem hiding this comment.
shall we pass args too?
There was a problem hiding this comment.
this is not needed, the upstream operator has no positional args. It only has named/keyword args.
|
Tested the DAG it worked fine with the RC, din't not encounter the issue that Wei has reported on RC Voting thread. 
|
pankajkoti
approved these changes
Feb 14, 2024
pankajkoti
reviewed
Feb 14, 2024
setup.cfg
Outdated
Comment on lines
47
to
48
| # Update version when the below RC is released | ||
| apache-airflow-providers-amazon>=8.18.0rc1 |
There was a problem hiding this comment.
Suggested change
| # Update version when the below RC is released | |
| apache-airflow-providers-amazon>=8.18.0rc1 | |
| apache-airflow-providers-amazon>=8.18.0 |
setup.cfg
Outdated
Comment on lines
122
to
123
| # Update version when the below RC is released | ||
| apache-airflow-providers-amazon>=8.18.0rc1 |
There was a problem hiding this comment.
Suggested change
| # Update version when the below RC is released | |
| apache-airflow-providers-amazon>=8.18.0rc1 | |
| apache-airflow-providers-amazon>=8.18.0 |
pankajkoti
force-pushed
the
deprecate-SageMakerTrainingOperatorAsync
branch
from
35f1b4c to
2f23555
Compare
19 tasks
pankajkoti
reviewed
Feb 18, 2024
pankajkoti
force-pushed
the
deprecate-SageMakerTrainingOperatorAsync
branch
from
eff7b31 to
605f33d
Compare
pankajkoti
approved these changes
Feb 18, 2024
|
I will merge this so that we can test our regressions DAGs together on all RCs and create a separate PR later to update the versions in |
pankajkoti
requested review from
phanikumv,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate SageMakerTrainingOperatorAsync and proxy them to their Airflow OSS provider's counterpart.
this needs to wait for the release of apache/airflow#36685