Handle case for branch rebase/force push #109
Conversation
| echo "event that triggered the workflow: $GITHUB_REF" | ||
| branch=$(echo "${GITHUB_REF#refs/heads/}") | ||
| git fetch origin $branch | ||
| if ! git cat-file -e "${{ github.event.before }}" 2>/dev/null; then |
There was a problem hiding this comment.
in case of force push, we would get a commit hash, which won't exist in the git history due to force push
| DAGS_ONLY_DEPLOY=false | ||
| SKIP_IMAGE_OR_DAGS_DEPLOY=false | ||
| files=() | ||
| echo "Manual workflow dispatch or a new branch or tag creation, hence missing github event before and/or after commit hash" |
There was a problem hiding this comment.
Should we remove references to manual workflow dispatch?
There was a problem hiding this comment.
manual workflow dispatch will also have the GitHub event before and after as empty/null right? Or am I missing anything?
There was a problem hiding this comment.
I thought we were removing manual workflow dispatch as a way of invoking this?
There was a problem hiding this comment.
nope, only fixing the case for rebase/force push, while ensuring manual workflow dispatch works as it is.
There was a problem hiding this comment.
merging this PR, but let me know if we still need to adjust the log statement, happy to handle it.
Changes:
Testing:
Relates to #95