Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tasks that shouldn't run on skip_deploy #63

Closed
wants to merge 2 commits into from

Conversation

benjy44
Copy link

@benjy44 benjy44 commented Jun 3, 2024

  • Skip tasks that shouldn't run on skip_deploy
  • use $(git rev-parse HEAD^) instead of github.event.before, so squashed commits that are forced-pushed work

I had opened a PR earlier that was not properly tested, but this one should be better and tested, it fixes two issues we were facing with our deployments

@benjy44
Copy link
Author

benjy44 commented Aug 9, 2024

Hi @sunkickr @iancmoritz , any chance to review this PR?

use $(git rev-parse HEAD^) instead of github.event.before, so squashed commits that are forced-pushed work
@benjy44 benjy44 force-pushed the main branch 2 times, most recently from 6efb7e8 to b564d01 Compare August 14, 2024 08:00
@benjy44
Copy link
Author

benjy44 commented Aug 14, 2024

I've had the same issue that made me open this PR in the first place with the latest change pushed to wake up deployments. So I added the same change for those steps, ie: skip the steps that should not run on skip_deploy (without this change, the action breaks when preview deployment is being deleted)

@benjy44
Copy link
Author

benjy44 commented Dec 20, 2024

closing this as it didn't get much interests from the maintainers and the action has changed signigicantly since my PR.
Maybe the issues I mentioned are already fixed
I can see the current action still uses git diff --name-only $GITHUB_EVENT_BEFORE $GITHUB_EVENT_AFTER so squash commits are still broken most likely

@benjy44 benjy44 closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant