Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete button for Variables, Pools, Connections and Dag Runs #114

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

atulya-astronomer
Copy link
Contributor

No description provided.

@atulya-astronomer atulya-astronomer linked an issue Dec 10, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 30.15873% with 44 lines in your changes missing coverage. Please review.

Project coverage is 37.99%. Comparing base (de68415) to head (6f23f93).
Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
...tronomer_starship/compat/starship_compatability.py 29.72% 26 Missing ⚠️
tests/docker_test/docker_test.py 7.69% 12 Missing ⚠️
tests/api_integration_test.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   41.28%   37.99%   -3.30%     
==========================================
  Files          16       11       -5     
  Lines        1153     1166      +13     
==========================================
- Hits          476      443      -33     
- Misses        677      723      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fritz-astronomer fritz-astronomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 wonderfully done. Tests passing?
Consider adding to the docker tests, as well, to get an easy answer of if this works across AF versions
https://github.com/astronomer/starship/blob/main/tests/docker_test/docker_test.py

@atulya-astronomer atulya-astronomer merged commit b854d53 into main Dec 17, 2024
3 checks passed
@atulya-astronomer atulya-astronomer deleted the 80-add-delete branch December 17, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Delete Route+button to Starship entities
3 participants