Fix import script github action #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichung08
commented
Aug 21, 2024
Comment on lines
+19
to
+22
| strategy: | ||
| matrix: | ||
| goos: [ linux, windows, darwin ] | ||
| goarch: [ amd64, arm64 ] |
There was a problem hiding this comment.
generate binary for each combination of os and arch
vandyliu
approved these changes
Aug 21, 2024
vandyliu
reviewed
Aug 21, 2024
| run: | | ||
| output_name="terraform-provider-astro-import-script_${{ matrix.goos }}_${{ matrix.goarch }}" | ||
| if [ "${{ matrix.goos }}" = "windows" ]; then | ||
| output_name="${output_name}.exe" |
There was a problem hiding this comment.
can we also add the version to the binary names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build and release import script github action
🎟 Issue(s)
🧪 Functional Testing
tested via dry run: https://github.com/astronomer/terraform-provider-astro/actions/runs/10495912863/job/29075446396?pr=136
📸 Screenshots
📋 Checklist
examples/directory