133 bug bash script fixes #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichung08
commented
Aug 22, 2024
| @@ -33,7 +35,7 @@ func main() { | |||
| log.Println("Terraform Import Script Starting") | |||
|
|
|||
| // collect all arguments from the user, indicating all the resources that need to be imported | |||
| resourcesPtr := flag.String("resources", "", "Comma separated list of resources to import. The only accepted values are workspace, deployment, cluster, api_token, team, team_roles, user_roles") | |||
| resourcesPtr := flag.String("resources", "workspace,deployment,cluster,api_token,team,team_roles,user_roles", "Comma separated list of resources to import. The only accepted values are workspace, deployment, cluster, api_token, team, team_roles, user_roles") | |||
There was a problem hiding this comment.
added default value
when users run ./import_script even when -resource flag is not set we will automatically default to importing all resources - is this ok?
| } | ||
|
|
||
| // Define the minimum required version | ||
| minVersion, _ := version.NewVersion("1.7.0") |
There was a problem hiding this comment.
asks users to update terraform if version is not > 1.7.0
| @@ -269,6 +275,70 @@ func printHelp() { | |||
| log.Println("\nNote: If the -token flag is not provided, the script will attempt to use the ASTRO_API_TOKEN environment variable.") | |||
| } | |||
|
|
|||
| func checkRequiredArguments(resourcesPtr string, tokenPtr string, organizationIdPtr string) error { | |||
There was a problem hiding this comment.
checks that required args are set
vandyliu
reviewed
Aug 22, 2024
| @@ -33,7 +35,7 @@ func main() { | |||
| log.Println("Terraform Import Script Starting") | |||
|
|
|||
| // collect all arguments from the user, indicating all the resources that need to be imported | |||
| resourcesPtr := flag.String("resources", "", "Comma separated list of resources to import. The only accepted values are workspace, deployment, cluster, api_token, team, team_roles, user_roles") | |||
| resourcesPtr := flag.String("resources", "workspace,deployment,cluster,api_token,team,team_roles,user_roles", "Comma separated list of resources to import. The only accepted values are workspace, deployment, cluster, api_token, team, team_roles, user_roles") | |||
vandyliu
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎟 Issue(s)
🧪 Functional Testing
📸 Screenshots
📋 Checklist
examples/directory