Fix Bug in Role Helper #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandyliu
reviewed
Aug 23, 2024
|
|
||
| // get list of workspaceIds | ||
| workspaceIds := lo.Map(input.WorkspaceRoles, func(role iam.WorkspaceRole, _ int) string { | ||
| return role.WorkspaceId | ||
| }) | ||
|
|
||
| // check if deploymentWorkspaceIds are in workspaceIds | ||
| workspaceIds = lo.Intersect(lo.Uniq(workspaceIds), lo.Uniq(deploymentWorkspaceIds)) | ||
| workspaceIds = lo.Intersect(lo.Uniq(workspaceIds), deploymentWorkspaceIds) |
There was a problem hiding this comment.
can we have a test case where before this change it would fail and after it would pass
vandyliu
reviewed
Aug 23, 2024
| }, | ||
| { | ||
| Role: "DEPLOYMENT_ADMIN", | ||
| EntityId: "cm070pg0r00wd01qgnskk0dir", |
There was a problem hiding this comment.
where did this deploymentId come from?
should we create a deployment for this test and use that one instead?
vandyliu
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in
ValidateWorkspaceDeploymentRoleswhere users weren't able to assign multiple deployment roles under the same workspace🎟 Issue(s)
🧪 Functional Testing
📸 Screenshots
📋 Checklist
examples/directory