Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial PR: Setup, Workspace Resource and Workspace Data source #3

Merged
merged 16 commits into from
Apr 4, 2024
Merged

Initial PR: Setup, Workspace Resource and Workspace Data source #3

merged 16 commits into from
Apr 4, 2024

Conversation

vandyliu
Copy link
Collaborator

@vandyliu vandyliu commented Apr 3, 2024 •
edited
Loading

Description

This is the initial PR that bootstraps the repo so others can begin to develop on it.

  • adds unit tests
  • adds the core api clients and generates them
  • adds the workspace resource and data source
  • edits the github actions to run unit tests and format check
  • adds some isCuid validators
  • decided against using mock clients for now since they don't seem to work well with

Motivation

https://github.com/astronomer/astro/issues/19656
https://github.com/astronomer/astro/issues/19655

Testing

  • Added unit tests
  • Tested manually
  • Acceptance integration tests will need to be added later

@vandyliu vandyliu changed the title Workspace Initial PR: Setup, Workspace Resource and Workspace Data source Apr 3, 2024
@vandyliu vandyliu marked this pull request as ready for review April 4, 2024 00:48
@vandyliu vandyliu merged commit 145425c into main Apr 4, 2024
4 checks passed
@vandyliu vandyliu deleted the workspace branch April 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vandyliu