Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cluster Options Datasource #32

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Add Cluster Options Datasource #32

merged 8 commits into from
Apr 22, 2024

Conversation

aliotta
Copy link
Contributor

@aliotta aliotta commented Apr 22, 2024 •
edited
Loading

Description

Adds the cluster options datasource

🎟 Issue(s)

#15

🧪 Functional Testing

Unit tests added

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make fmt before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@aliotta aliotta requested review from vandyliu, sunkickr and a team as code owners April 22, 2024 16:01
@sunkickr
Copy link

could you provide an example of what using the datasource would look like?

vandyliu
vandyliu reviewed Apr 22, 2024
View reviewed changes
docs/data-sources/cluster_options.md
ClusterOptions data source
---

# astronomer_cluster_options (Data Source)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add to examples/ and re-generate the docs which will auto add the examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vandyliu
Copy link
Collaborator

can we update the pr description as well

@aliotta aliotta changed the title clusterOptionsDatasource Add Cluster Options Datasource Apr 22, 2024
@aliotta
Copy link
Contributor Author

aliotta commented Apr 22, 2024

could you provide an example of what using the datasource would look like?

done

@aliotta aliotta requested a review from vandyliu April 22, 2024 19:46
@aliotta aliotta merged commit 37ad135 into main Apr 22, 2024
5 checks passed
@aliotta aliotta deleted the clusterOptionsDatasource branch April 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandyliu vandyliu vandyliu approved these changes

@sunkickr sunkickr Awaiting requested review from sunkickr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliotta @sunkickr @vandyliu