Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oneof validation to cluster options type #35

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Add oneof validation to cluster options type #35

merged 3 commits into from
Apr 23, 2024

Conversation

vandyliu
Copy link
Collaborator

@vandyliu vandyliu commented Apr 23, 2024 •
edited
Loading

Description

Fix validation for cluster options and fix release workflow

🎟 Issue(s)

Fix bug

🧪 Functional Testing

  • added test

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Tested against Astro-API
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vandyliu vandyliu requested review from sunkickr and a team as code owners April 23, 2024 17:54
@vandyliu vandyliu enabled auto-merge (squash) April 23, 2024 18:21
@vandyliu vandyliu merged commit b5bb9ff into main Apr 23, 2024
5 checks passed
@vandyliu vandyliu deleted the fix-cluster-option-type-bug branch April 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredzhy fredzhy fredzhy approved these changes

@sunkickr sunkickr Awaiting requested review from sunkickr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandyliu @fredzhy