Add original astro runtime version to deployment resource creation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com:astronomer/terraform-provider-astro into add-astro-runtime-version-to-deployment-resource-v2
frank-ye
reviewed
May 15, 2024
| @@ -12,7 +12,7 @@ OAPI_CODEGEN ?= $(ENVTEST_ASSETS_DIR)/oapi-codegen | |||
| # Run acceptance tests | |||
| .PHONY: testacc | |||
| testacc: | |||
| TF_ACC=1 go test ./... -v -run TestAcc $(TESTARGS) -timeout 120m | |||
| TF_ACC=1 go test ./... -v -run TestAcc $(TESTARGS) -timeout 180m | |||
There was a problem hiding this comment.
Just curious about the increase here, is this due to the resource tests being added?
There was a problem hiding this comment.
Seems like the tests take 2.5 hours to run (and pass) so I upped it
frank-ye
reviewed
May 15, 2024
frank-ye
reviewed
May 15, 2024
frank-ye
reviewed
May 15, 2024
| // Hybrid deployment specific fields | ||
| TaskPodNodePoolId types.String `tfsdk:"task_pod_node_pool_id"` | ||
|
|
||
| // Hosted deployment specific fields |
There was a problem hiding this comment.
nit: since you mentioned dedicated above, so that we don't have to infer what you mean by hosted below
Suggested change
| // Hosted deployment specific fields | |
| // Hosted (shared and dedicated) deployment specific fields |
frank-ye
reviewed
May 15, 2024
| return diags | ||
| } | ||
| data.Executor = types.StringPointerValue((*string)(deployment.Executor)) | ||
| if deployment.SchedulerAu != nil { |
There was a problem hiding this comment.
Since we're starting by reading common fields, should we move this lower, in the hybrid only section? Perhaps with the TaskPodNodePoolId? Might've missed it, but this comment is just based off how you re-organized the deployment resource fields to read from the response!
frank-ye
approved these changes
May 15, 2024
vandyliu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎟 Issue(s)
#astro
🧪 Functional Testing
original_astro_runtime_versionset, with it not set and also importing an existing deployment📸 Screenshots
📋 Checklist
examples/directory