Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment env vars not working if is_secret=True #60

Merged
merged 16 commits into from
May 16, 2024

Conversation

vandyliu
Copy link
Collaborator

@vandyliu vandyliu commented May 14, 2024

Description

  • Previously, environment variables with is_secret=True emit errors in Terraform
  • On create, update, and read for deployment resources, we must give Terraform the actual secret value so it doesnt error out and see inconsistencies. The value field is sensitive though so it is not outputted, however it is necessary so Terraform doesn't complain and error out.

🎟 Issue(s)

#45

🧪 Functional Testing

  • Added acceptance integration tests
  • Also works with imported deployment

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Tested against Astro-API
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vandyliu vandyliu marked this pull request as ready for review May 15, 2024 07:32
@vandyliu vandyliu requested review from sunkickr and a team as code owners May 15, 2024 07:32
@vandyliu vandyliu changed the title Fix deployment env vars Fix deployment env vars not working if is_secret=True May 15, 2024
@vandyliu vandyliu merged commit 0ba1d5e into main May 16, 2024
5 checks passed
@vandyliu vandyliu deleted the fix-deployment-env-vars branch May 16, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants