Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployments data source #7

Merged
merged 11 commits into from
Apr 10, 2024
Merged

Deployments data source #7

merged 11 commits into from
Apr 10, 2024

Conversation

vandyliu
Copy link
Collaborator

@vandyliu vandyliu commented Apr 9, 2024 •
edited
Loading

Description

This PR

  • adds deployments data source
  • adds deployment data source
  • removes organization_name from workspace resource and data source since it is not necessary to have
  • adds some helpers for creating types.List that will be used often

🎟 Issue(s)

https://github.com/astronomer/astro/issues/19657

🧪 Functional Testing

  • Will add acceptance tests in a follow up PR
  • Tested with terraform apply

📸 Screenshots

Screenshot 2024-04-09 at 5 10 23 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make fmt before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vandyliu vandyliu marked this pull request as ready for review April 10, 2024 00:11
@vandyliu vandyliu requested review from sunkickr and a team as code owners April 10, 2024 00:11
kushalmalani
kushalmalani approved these changes Apr 10, 2024
View reviewed changes
Copy link

@kushalmalani kushalmalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Left some minor comments. Seems like you resolved those.

@vandyliu vandyliu merged commit a21650c into main Apr 10, 2024
4 checks passed
@vandyliu vandyliu deleted the deployments-data-source branch April 10, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalmalani kushalmalani kushalmalani approved these changes

@sunkickr sunkickr Awaiting requested review from sunkickr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandyliu @kushalmalani