Add deployment resource

[vandyliu]

Description

• adds deployment resource and some basic acceptance tests for standard and hybrid deployments
• will add acceptance tests for dedicated deployments once dedicated_cluster_resource is implemented
• adds deployment data source and deployments data source acceptance tests

🎟 Issue(s)

#10

🧪 Functional Testing

Hosted deployment config

resource "astronomer_deployment" "test_deployment1" {
    name = "tf--1"
    description = "%v"
    type = "DEDICATED"
    cluster_id = "clv17vgft000801kkydsws63x"
    contact_emails = ["[email protected]"]
    default_task_pod_cpu = "0.25"
    default_task_pod_memory = "0.5Gi"
    executor = "KUBERNETES"
    is_cicd_enforced = true
    is_dag_deploy_enabled = true
    is_development_mode = false
    is_high_availability = true
    resource_quota_cpu = "10"
    resource_quota_memory = "20Gi"
    scheduler_size = "SMALL"
    workspace_id = astronomer_workspace.test_workspace.id
    environment_variables = [{
        key = "key1"
        value = "value1"
        is_secret = false
    }]
}

resource "astronomer_deployment" "test_deployment2" {
    name = "tf--2"
    description = "%v"
    type = "STANDARD"
    cloud_provider = "AWS"
    region = "us-east-1"
    contact_emails = []
    default_task_pod_cpu = "0.25"
    default_task_pod_memory = "0.5Gi"
    executor = "CELERY"
    is_cicd_enforced = true
    is_dag_deploy_enabled = true
    is_development_mode = false
    is_high_availability = false
    resource_quota_cpu = "10"
    resource_quota_memory = "20Gi"
    scheduler_size = "SMALL"
    workspace_id = astronomer_workspace.test_workspace.id
    environment_variables = []
    worker_queues = [{
        name = "default"
        is_default = true
        astro_machine = "A5"
        max_worker_count = 10
        min_worker_count = 0
        worker_concurrency = 1
    }]
}

Hybrid deployment config

resource "astronomer_deployment" "test_deployment1" {
        name = "tf--1"
        description = "%v"
        type = "HYBRID"
        cluster_id = "clnp86ly5000401ndagu20g81"
        task_pod_node_pool_id = "clnp86ly5000301ndzfxz895w"
        contact_emails = ["[email protected]"]
        executor = "KUBERNETES"
        is_cicd_enforced = true
        is_dag_deploy_enabled = true
        scheduler_replicas = 1
        scheduler_au = 5
        workspace_id = astronomer_workspace.test_workspace.id
        environment_variables = [{
            key = "key1"
            value = "value1"
            is_secret = false
        }]
    }

📸 Screenshots

📋 Checklist

• Rebased from the main (or release if patching) branch (before testing)
• Ran make test before taking out of draft
• Ran make fmt before taking out of draft
• Added/updated applicable tests
• Tested against Astro-API (if necessary).
• Communicated to/tagged owners of respective clients potentially impacted by these changes.
• Updated any related documentation

[vandyliu]

moved into data_worksapces_test.go since code is similar and we can check both in same test using same workspace resource

[vandyliu]

don't need this anymore since there's actually a list validator we can use

[vandyliu]

.ValueString() gives us the actual string str
.String() gives us "str"

[fredzhy]

are we just writing these manually every time?

[vandyliu]

its generated by tfplugindocs (line 1) made by make build
defined by our schema

[fredzhy]

general question, is it conventional to have separate data sources to each of the oneof types?

[vandyliu]

i cant find many examples since it seems that most of the time the API matches the terraform provider in terms of resources.
Let me take a stab at making it all the same (ie. deployment_resource) to see what complexities it may bring up

[kushalmalani]

Should this be required? I believe a user can update this via cli

[vandyliu]

its a weird one because it is auto-generated if no input
furthermore it can only be done for certain deployments like aws hybrid deployments and gcp hosted deployments so we cant have it be required nor optional

if we set it to optional and it is blank then terraform will complain because the astro api sets it but terraform expects it to be blank

[kushalmalani]

What would the user do if they use aws hybrid dpeloyments and want to update workload_identity. Dont want to block this PR because of this, but something for us to think about

[vandyliu]

they can update it via API and the value will be left alone if terraform ever does any updates

[fredzhy]

thanks for the walk through yesterday, i think we can merge this and start internal testing

[kushalmalani]

Looks good. Thanks