BUG: fix an incoming incompatibility with Python 3.15 (locale.getdefaultlocale is deprecated in Python 3.12)
#3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
locale.getdefaultlocale is deprecated in Python 3.12)
neutrinoceros
force-pushed
the
compat/locale_depr
branch
from
ba35b91
to
db7cf97
Compare
…ultlocale is deprecated in Python 3.12)
neutrinoceros
force-pushed
the
compat/locale_depr
branch
from
db7cf97
to
ac51de6
Compare
keflavich
approved these changes
Jul 22, 2024
|
Good question. I think it originated in
so maybe it should just be removed here instead of fixed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
https://docs.python.org/3/library/locale.html#locale.getdefaultlocale
and
https://docs.python.org/3/library/locale.html#locale.getencoding