fix warning message in FitTrace when many bins masked #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
force-pushed
the
mask_fit_trace
branch
from
bb44040 to
a334e98
Compare
kecnry
reviewed
Dec 4, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 81.32% 81.61% +0.29%
==========================================
Files 10 10
Lines 996 1001 +5
==========================================
+ Hits 810 817 +7
+ Misses 186 184 -2 ☔ View full report in Codecov by Sentry. |
kecnry
reviewed
Dec 11, 2023
cshanahan1
force-pushed
the
mask_fit_trace
branch
from
174dd0e to
5f72ca7
Compare
kecnry
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates warning messages that were previously produced for each individual masked column into one message reporting all masked columns, or that many columns were masked if there are more than 20.