Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: pin extension-helpers to 1.* following upstream recommendation #200

Closed
wants to merge 1 commit into from
Closed

BLD: pin extension-helpers to 1.* following upstream recommendation #200

wants to merge 1 commit into from

Conversation

neutrinoceros
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (648c861) 78.83% compared to head (00e15c7) 78.83%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files          10       10           
  Lines         992      992           
=======================================
  Hits          782      782           
  Misses        210      210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Dec 5, 2023 •
edited
Loading

The devdeps failure is unrelated. Please let me know if you need a hand with it, I'd be happy to help !

@neutrinoceros
Copy link
Contributor Author

ping @hamogu

kecnry
kecnry approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - thanks! Any concerns @tepickering?

@kecnry kecnry requested a review from tepickering December 5, 2023 13:02
@pllim
Copy link
Member

pllim commented Dec 5, 2023

Wait a minute, why is it even a build dependency here? I don't see any C-extension.

@neutrinoceros neutrinoceros mentioned this pull request Dec 5, 2023
Merged
@neutrinoceros
Copy link
Contributor Author

Indeed, thanks for catching this ! Superseded by #201

@neutrinoceros neutrinoceros deleted the pin-extension-helpers branch December 5, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecnry kecnry kecnry approved these changes

@tepickering tepickering Awaiting requested review from tepickering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neutrinoceros @pllim @kecnry