set bin peaks to NaN in FitTrace when fully masked bin is encountered #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
changed the title
cshanahan1
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 81.82% 81.77% -0.06%
==========================================
Files 10 10
Lines 1007 1004 -3
==========================================
- Hits 824 821 -3
Misses 183 183 ☔ View full report in Codecov by Sentry. |
cshanahan1
force-pushed
the
set_to_nan_FitTrace
branch
from
5c21308 to
83d7deb
Compare
kecnry
reviewed
Jan 25, 2024
kecnry
reviewed
Jan 26, 2024
kecnry
approved these changes
Jan 26, 2024
consolidate change log entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #206
(review after #205 is merged)