Fix how empty arrays are handled by expressions #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
This PR fixes an issue with how empty arrays, provided via an expando object, are handled by the rules engine. System.Linq is checking the data type of the expected underlying object before comparing the contents of the actual object. This is causing issues when empty arrays are provided in json bodies, and these get converted to a
List<object>
. If you have a rule expression that looks something likewidgets.Any(a == 3)
, andwidgets
is an empty array, the expression parser in System.Linq would experience an issue comparing anobject
to an integer.To fix this issue, this PR creates a new class named
ImplicitObject
which contains implicit operators for every logical data type that can be passed in from a json object.Run the following code: