version updated #86
version updated #86
Conversation
asulwer
commented
Nov 15, 2024
•
asulwer
commented
- RulesEngine.cs - UpdateErrorMessage, wrapped block in using statement
- removed unused using statements
- updated RulesEngine version to include changes from issue #75
- targeting NetStandard2.0 AND 2.1
2. removed unused using statements 3. updated RulesEngine version
asulwer
changed the title
|
fyi: if you upgrade to VS 2022 17.12 it 'removes' Net 8 and installs Net 9. project would not build because of the removal of Net 8 |
|
Out of curiosity, what prompted you to support netstandard2.0? I was going to propose this due to integration requirements with an older app I'm working with, but looks like you already took care of this. |
| namespace RulesEngine.Models | ||
| { | ||
| [ExcludeFromCodeCoverage] | ||
| public class ImplicitObject | ||
| { | ||
|
|
||
| #region Implicit Operators |
There was a problem hiding this comment.
Do we not want region blocks?
There was a problem hiding this comment.
the region wraps one block of code. in my opinion, it isn't necessary
i saw that you had it enabled in your branch. what can it hurt supporting it? |
|
All good thanks |
Works for me. thanks! |
