Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

fix: add support for parameters #69 #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kvimbi
Copy link

@kvimbi kvimbi commented Mar 21, 2023

fix: Add support for parameters in channels placing it in quotation marks
fix: Add missing for the rest of the lines

Fixes issue #69

fix: Add support for parameters in channels placing it in quotation marks
fix: Add missing for the rest of the lines 

Fixes issue asyncapi-archived-repos#69
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kvimbi kvimbi changed the title fix: Add support for parameters #69 fix: add support for parameters #69 Mar 21, 2023
@derberg
Copy link
Collaborator

derberg commented Mar 30, 2023

@arjungarg07 can you have a look 🙏🏼

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kvimbi
Copy link
Author

kvimbi commented Mar 31, 2023

Sorry forgot to check the tests.
I've fixed them and they are passing now.

@derberg
Copy link
Collaborator

derberg commented May 23, 2023

@arjungarg07 please have a look

@derberg
Copy link
Collaborator

derberg commented Jun 21, 2023

@arjungarg07 any chance you could have a look?

@arjungarg07
Copy link
Collaborator

Sure, will check

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants