Skip to content

Commit

Permalink
Add useChannelAddressAsIdentifier configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
diegotorresd committed Jun 24, 2024
1 parent 99bce32 commit 9add575
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 1 deletion.
3 changes: 3 additions & 0 deletions docs/configuration/config-modification.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ interface ConfigInterface {
sidebar?: {
showServers?: 'byDefault' | 'bySpecTags' | 'byServersTags';
showOperations?: 'byDefault' | 'bySpecTags' | 'byOperationsTags';
useChannelAddressAsIdentifier?: boolean;
},
parserOptions?: ParserOptions;
publishLabel?: string;
Expand All @@ -52,6 +53,8 @@ interface ConfigInterface {
This field contains configuration responsible for the way of working of the sidebar.
`showServers` field is set to `byDefault` by default.
`showOperations` field is set to `byDefault` by default.
`useChannelAddressAsIdentifier` uses the channel address or operation summary in the sidebar instead of the operationId, for both AsyncAPI v2 and v3 documents.
The default behaviour is to do this only for v2 documents.

- **expand?: Partial<ExpandConfig>**

Expand Down
1 change: 1 addition & 0 deletions library/src/config/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,5 @@ export interface ExpandConfig {
export interface SideBarConfig {
showServers?: 'byDefault' | 'bySpecTags' | 'byServersTags';
showOperations?: 'byDefault' | 'bySpecTags' | 'byOperationsTags';
useChannelAddressAsIdentifier?: boolean;
}
2 changes: 1 addition & 1 deletion library/src/containers/Sidebar/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ const OperationsList: React.FunctionComponent = () => {
numeric: true,
});
let label = '';
if (version === 0) {
if (version === 0 || sidebarConfig?.useChannelAddressAsIdentifier) {
// old version uses different labels for the operations
const operationChannels = operationChannel.all();
const channelAddress = operationChannels[0]?.address() ?? '';
Expand Down
24 changes: 24 additions & 0 deletions library/src/containers/Sidebar/__tests__/SideBar.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,28 @@ describe('Sidebar component', () => {
</ConfigContext.Provider>,
);
});
test('should render with useChannelAddressAsIdentifier: true', () => {
const { container } = render(
<ConfigContext.Provider
value={{ sidebar: { useChannelAddressAsIdentifier: true } }}
>
<SpecificationContext.Provider value={parsed}>
<Sidebar />
</SpecificationContext.Provider>
</ConfigContext.Provider>,
);
const operations = container.querySelectorAll('a[href^="#operation-"]');
const expectedOperationDescriptions = [
'Inform about environmental lighting conditions of a particular streetlight.', // because the channel has a summary
'smartylighting.streetlights.1.0.action.{streetlightId}.turn.on',
'smartylighting.streetlights.1.0.action.{streetlightId}.turn.off',
'smartylighting.streetlights.1.0.action.{streetlightId}.dim',
];
for (let i = 0; i < operations.length; i++) {
// eslint-disable-next-line jest/no-standalone-expect
expect(operations[i].querySelectorAll('span')[1].textContent).toBe(
expectedOperationDescriptions[i],
);
}
});
});

0 comments on commit 9add575

Please sign in to comment.