Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Message ID block if messageId is not set #1049

Closed
Vaniog opened this issue Sep 22, 2024 · 9 comments · Fixed by #1061
Closed

Hide Message ID block if messageId is not set #1049

Vaniog opened this issue Sep 22, 2024 · 9 comments · Fixed by #1061
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released

Comments

@Vaniog
Copy link

Vaniog commented Sep 22, 2024

Description

Remove block [Message ID] presented on the photo, if message has no property "messageId" (as in attached specification)

Reasons

This duplicate information and take a lot of space

Attachments

asyncapi: 3.0.0
info:
  title: Hello world application
  version: '0.1.0'
channels:
  hello:
    address: 'hello'
    messages:
      sayHelloMessage:
        payload:
          type: string
operations:
  receiveHello:
    action: 'receive'
    channel:
      $ref: '#/channels/hello'

image

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ItshMoh
Copy link
Contributor

ItshMoh commented Sep 26, 2024

Hey @Vaniog can you explain what are you trying to say in the issue. As the spec you have shared is containing the {messagId}
. For this doc it is 'sayHelloMessage' . You can refer here.
let me know what are your thoughts.

@Vaniog
Copy link
Author

Vaniog commented Sep 26, 2024

In this case messageId is same as message name. But you can set messageId property, as in spec below.

components:
  messages:
    sayHelloMessage:
      messageId: notSayHelloMessage
      payload:
        type: object
        properties:
          name:
            type: string

So message name and messageId will be different
In case, which i provided in issue, these properties are same, so i dont want to see both of them in message header (screenshot)

@ItshMoh
Copy link
Contributor

ItshMoh commented Sep 27, 2024

Hey @Vaniog In asyncapi version 3.0.0 it is not valid. You can't specify the messageID in the spec. Here You can again refer.
I have tried you spec in studio.
messageID_conf

@Vaniog
Copy link
Author

Vaniog commented Sep 27, 2024

Yes. And so displaying message name and messageId separately in viewer is deprecated too.

@ItshMoh
Copy link
Contributor

ItshMoh commented Sep 28, 2024

Hey @AceTheCreator Would it be fine to remove one of the messageID, as both are the same. Is it for some other purposes?
what's your suggestion, if it is a valid issue or not?

@AceTheCreator AceTheCreator added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Sep 30, 2024
@AceTheCreator
Copy link
Member

@ItshMoh, yea, we should remove the first one 👍🏾

ManikantaMandala added a commit to ManikantaMandala/asyncapi-react that referenced this issue Oct 2, 2024
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants