Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed redundant MessageId #1061

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

ManikantaMandala
Copy link
Contributor

fixes #1049

Description

Changes proposed in this pull request:

  • Removed redundant MessageId from Message.tsx

Before:
image

After:
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ManikantaMandala ManikantaMandala marked this pull request as draft October 2, 2024 17:23
@ManikantaMandala ManikantaMandala changed the title fix: Removed redundant MessageId fix: removed redundant MessageId Oct 2, 2024
@ManikantaMandala ManikantaMandala marked this pull request as ready for review October 3, 2024 05:59
@AceTheCreator AceTheCreator self-requested a review as a code owner October 7, 2024 17:43
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Oct 14, 2024

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 6942952 into asyncapi:master Oct 14, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Vaniog
Copy link

Vaniog commented Oct 14, 2024

@ManikantaMandala thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Message ID block if messageId is not set
4 participants