fix: update web-component bumping script for react #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
magicmatatjahu,
fmvilas and
asyncapi-bot-eve
as code owners
|
@magicmatatjahu it fails because of package-lock caused by the issue that this PR solves. Once you approve I will merge as admin |
magicmatatjahu
approved these changes
Jun 26, 2024
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like depending on npm versions there are different behaviours of installation
even though existing script has explicit
--save, if some other script in the same run updated dependency to lates, and it is already in node_modules, installation of the same dependency with--savein another project in monorepo, will not result in updates in package.jsonThis this PR introduce initial remove of dependency and then fresh installation