Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed the redundant react-fragment #1055

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+21 −23
Open

refactor: removed the redundant react-fragment #1055

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79cc231
removing the fragment sign.
ItshMoh Sep 30, 2024
c553043
Merge branch 'master' into split_red
AceTheCreator Oct 7, 2024
4d6741f
Merge branch 'master' into split_red
AceTheCreator Oct 7, 2024
1855313
fixed the linting issue
ItshMoh Oct 8, 2024
9e54196
Merge branch 'master' into split_red
AceTheCreator Nov 4, 2024
950e277
Merge branch 'master' into split_red
AceTheCreator Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions playground/components/SplitWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@

// react-split should be replaced with a React 18 friendly library or CSS
const SplitWrapper = (props: SplitWrapperProps) => (
<>
<Split

Check failure on line 10 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
style={{

Check failure on line 11 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
width: '100%',

Check failure on line 12 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
height: 'calc(100vh - 50px)',

Check failure on line 13 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
minHeight: 'calc(100vh - 50px)',

Check failure on line 14 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
display: 'flex',

Check failure on line 15 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Replace `········` with `······`
background: '#f3f4f5',

Check failure on line 16 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
}}

Check failure on line 17 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
gutter={() => {

Check failure on line 18 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
const gutter = document.createElement('div');

Check failure on line 19 in playground/components/SplitWrapper.tsx

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest 

Delete `··`
gutter.onmouseover = () => (gutter.style.cursor = 'ew-resize');
return gutter;
}}
Expand All @@ -29,7 +28,6 @@
>
{props.children}
</Split>
</>
);

export default SplitWrapper;
Loading