Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added semantic markup, strong instead of font-weight #1062

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

ItshMoh
Copy link
Contributor

@ItshMoh ItshMoh commented Oct 2, 2024

removed the css font-weight property and added the semantic markup strong.

Description

Related issue(s)
#957

@AceTheCreator AceTheCreator self-requested a review as a code owner October 7, 2024 17:43
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItshMoh
Copy link
Contributor Author

ItshMoh commented Oct 8, 2024

Kindly look into why test is failing https://github.com/asyncapi/asyncapi-react/actions/runs/11221464110/job/31191855048?pr=1062

@AceTheCreator hey i have fixed the issue.

Copy link

sonarcloud bot commented Oct 14, 2024

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 8f3212d into asyncapi:master Oct 14, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants