Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the focus: outline-none and added a visible focus. #1064

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added the focus for buttons.
ItshMoh committed Oct 3, 2024
commit 8b66b74a4330f93d9a9c4a7e4cea842011331aa7
2 changes: 1 addition & 1 deletion library/src/components/CollapseButton.tsx
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ export const CollapseButton: React.FunctionComponent<Props> = ({
}) => (
<button
{...rest}
className={`focus:outline-none ${rest.className}`}
className={`focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 ${rest.className}`}
type="button"
>
<div className="inline-block">{children}</div>
2 changes: 1 addition & 1 deletion library/src/containers/Messages/MessageExample.tsx
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@ export const Example: React.FunctionComponent<ExampleProps> = ({
className: 'fill-current text-gray-200',
}}
>
<span className="inline-block w-20 py-0.5 mr-1 text-gray-200 text-sm border text-center rounded focus:outline-none">
<span className="inline-block w-20 py-0.5 mr-1 text-gray-200 text-sm border text-center rounded focus:ring-2 focus:ring-blue-500 focus:ring-offset-2">
{type}
</span>
</CollapseButton>
4 changes: 2 additions & 2 deletions library/src/containers/Operations/Operation.tsx
Original file line number Diff line number Diff line change
@@ -300,7 +300,7 @@ export const OperationReplyInfo: React.FunctionComponent<Props> = (props) => {
onClick={() => setShowChannel((prev) => !prev)}
expanded={showChannel}
>
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:outline-none">
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:ring-2 focus:ring-blue-500 focus:ring-offset-2">
View channel details
</span>
</CollapseButton>
@@ -324,7 +324,7 @@ export const OperationReplyInfo: React.FunctionComponent<Props> = (props) => {
onClick={() => setShowMessages((prev) => !prev)}
expanded={showMessages}
>
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:outline-none">
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:ring-2 focus:ring-blue-500 focus:ring-offset-2">
Expected Reply{' '}
{replyMessages.length > 1 ? 'Messages' : 'Message'}
</span>