Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove the unexpected empty blocks #800

Merged
merged 2 commits into from
Oct 4, 2023
Merged

refactor: remove the unexpected empty blocks #800

merged 2 commits into from
Oct 4, 2023

Conversation

parasss19
Copy link
Contributor

@parasss19 parasss19 commented Oct 3, 2023 •
edited by derberg
Loading

Description

Changes proposed in this pull request:

  • Removed some unexpected empty blocks from the path library/src/styles/default.css

Related issue(s)
fixes #787

github-actions[bot]
github-actions bot reviewed Oct 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@parasss19
Copy link
Contributor Author

hey @derberg Please review it
Also provide labels like hacktoberfest2023, hacktoberfest-accepted on issues and my pr so that it would be accepted in hacktoberfest

@derberg
Copy link
Member

derberg commented Oct 4, 2023

no need for a label, repo has a proper topic already

Screenshot 2023-10-04 at 11 20 14

@derberg derberg changed the title fix: removed the unexpected empty blocks refactor: removed the unexpected empty blocks Oct 4, 2023
@derberg derberg changed the title refactor: removed the unexpected empty blocks refactor: remove the unexpected empty blocks Oct 4, 2023
@derberg
Copy link
Member

derberg commented Oct 4, 2023

I also changed the prefix of the PR as we do not need to release a fix, it is simple refactor that has no result on produced library, just a cleanup

derberg
derberg approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, happy Hacktoberfest 🍺

@derberg
Copy link
Member

derberg commented Oct 4, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 530f17d into asyncapi:master Oct 4, 2023
20 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected empty block
3 participants
@parasss19 @derberg @asyncapi-bot