Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add an operational chain instead of expressions check #803

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

syedzubeen
Copy link
Contributor

Description

Adds an operational chain instead of an expression check

Related issue(s)
Fixes #780

@derberg
Copy link
Member

derberg commented Oct 4, 2023

@syedzubeen Thanks for the PR. When you contribute to any project, especially open source, you should open a PR only once you are familiarized with contributing guide like https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md

  • please adjust your PR title:
    • use imperative mood in PR title
    • use proper conventional commits prefix (you have a bot comment with details - in your case it is refactor

@syedzubeen syedzubeen changed the title Adds an operational chain instead of expressions check refactor: add an operational chain instead of expressions check Oct 4, 2023
@syedzubeen
Copy link
Contributor Author

Done !

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@derberg
Copy link
Member

derberg commented Oct 7, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 1b893a4 into asyncapi:master Oct 7, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer using an optional chain expression instead, as it's more concise and easier to read.
3 participants