Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the redundant-jump code #807

Merged
merged 3 commits into from
Oct 9, 2023
Merged

refactor: remove the redundant-jump code #807

merged 3 commits into from
Oct 9, 2023

Conversation

parasss19
Copy link
Contributor

Description

Changes proposed in this pull request:
-Removed the redundant jump code

Related issue(s)
#785

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signature of functions that you modify say they return MessageExample[] | undefined so if you remove return tests fail. So please bring back return but as return undefined

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@parasss19 parasss19 requested a review from derberg October 8, 2023 07:00
@derberg
Copy link
Member

derberg commented Oct 9, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c54659d into asyncapi:master Oct 9, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants