Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add optional chain instead of expression #810

Closed
wants to merge 1 commit into from

Conversation

syedzubeen
Copy link
Contributor

Description

Add optional chain instead of an expression

Related issue(s)
Fixes #778

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@derberg
Copy link
Member

derberg commented Oct 7, 2023

@syedzubeen please run linter locally and fix related issue as now merging is not possible

@derberg
Copy link
Member

derberg commented Oct 11, 2023

@syedzubeen do you need some help with your PRs?

@parasss19
Copy link
Contributor

@syedzubeen do you need some help with your PRs?

Can i work on this issue?

@derberg
Copy link
Member

derberg commented Oct 16, 2023

@parasss19 I guess so, seems like @syedzubeen is no longer interested with this one

@parasss19
Copy link
Contributor

@parasss19 I guess so, seems like @syedzubeen is no longer interested with this one

hey @derberg i added the optional chain but there are many lint error and im not understanding it

Screenshot 2023-10-16 225805

@derberg
Copy link
Member

derberg commented Dec 18, 2023

Closing as looks like at the moment it is not clear how to fix this topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer using an optional chain expression instead, as it's more concise and easier to read.
3 participants