Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #143

Closed
wants to merge 1 commit into from
Closed

Conversation

M3lkior
Copy link
Collaborator

@M3lkior M3lkior commented Apr 26, 2022

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -30,7 +30,7 @@
},
"homepage": "https://github.com/asyncapi/avro-schema-parser#readme",
"devDependencies": {
"@asyncapi/parser": "^1.14.1",
"@asyncapi/parser": "^1.15.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a dev dependency, so I don't think so that PR is needed. If you only use this dependency for testing then the new changes (in parser core) do not have any breaking changes, so just bumping up the dependencies and the package does not make sense.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you have absolutely right :) it appears that my holidays was the best effect ^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah no problem, glad you got some rest. Generally this dependency will be bumped automatically, but without releasing the package - our workflow will take care of it :)

@smoya
Copy link
Member

smoya commented Apr 26, 2022

Sorry for the confusion. My message wasn't clear (now edited). The dependency bump will be done automatically by our CI/CD automation scripts, so this won't be needed 🙏

@M3lkior M3lkior closed this Apr 26, 2022
@derberg derberg deleted the feat/prepare-for-2022-04-release branch October 10, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants