chore: merge next-major into master

[smoya]

Description

This PR merges next-major branch into master.

Warning
DO NOT SQUASH. USE REBASE OR MERGE

next-major branch includes the rewrite to TypeScript and adapts to the new Parser-API interface.
It is BC (see commits included with feat!: prefix).

Related issue(s)
asyncapi/parser-js#481

[dalelane]

should we update this before merging into master?

[dalelane]

🎉

[derberg]

I really don't understand why this should not be feat!: and squash merged like any other release PR

[smoya]

I really don't understand why this should not be feat!: and squash merged like any other release PR

In this particular case, It is not very critical since I authored all changes in next-major branch. However, it is not a good practice to squash a long-live branch since you lose all commits history, including different commits with different authors. Additionally, minor thing here, you create a fake commit, with a wrong creation date, etc that doesn't represent the real work behind.

[derberg]

since you lose all commits history, including different commits with different authors

we don't loose history, it is all there. We use that approach for 3 years now and it was never a problem

you create a fake commit

it is not a fake commit, it is squash of all commits into one summary to have clean history.

---

also, why is this a chore: commit? we are merging here entire release branch into master

[smoya]

we don't loose history, it is all there. We use that approach for 3 years now and it was never a problem

If you squash commits into a single one, you lose history.

also, why is this a chore: commit? we are merging here entire release branch into master

It is chore since, if merged and not squashed, the commit feat!: implement new Parser-js interface will remain and added into master, so no need to add another feat!:

[smoya]

@derberg More discussion about it can be found in asyncapi/community#641

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[smoya]

Please @dalelane approve again. Had to update with base branch and your review got dismissed

[M3lkior]

ssed

done :)