Add test cases for more commands

asyncapi · Jan 4, 2025 · 2c5b6d1 · 2c5b6d1
1 parent 60390de
commit 2c5b6d1
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/src/core/models/SpecificationFile.ts b/src/core/models/SpecificationFile.ts
@@ -112,12 +112,12 @@ export class Specification {
         } catch (error) {
           throw new Error(`Invalid proxy URL: ${proxyUrl}`);
         }
-      }
-
-      response = await fetch(targetUrl);
-      if (!response.ok) {
+      } else {
+        response = await fetch(targetUrl);
+        if (!response.ok) {
         //   console.log(response+" sdf")
-        throw new ErrorLoadingSpec('url', targetUrl);
+          throw new ErrorLoadingSpec('url', targetUrl);
+        }
       }
     } catch (error) {
       console.log(error);

diff --git a/test/integration/convert.test.ts b/test/integration/convert.test.ts
@@ -58,6 +58,15 @@ describe('convert', () => {
         expect(ctx.stderr).to.equal('');
         done();
       });
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', 'http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080'])
+      .it('works when url is passed with proxyHost and proxyPort with invalid host ', (ctx, done) => {
+        expect(ctx.stdout).to.contain('');
+        expect(ctx.stderr).to.equal('error loading AsyncAPI document from url: Failed to download http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080.\n');
+        done();
+      });
   });
 
   describe('with no arguments', () => {

diff --git a/test/integration/optimize.test.ts b/test/integration/optimize.test.ts
@@ -58,6 +58,15 @@ describe('optimize', () => {
         expect(ctx.stderr).to.equal('');
         done();
       });
+    test
+      .stderr()
+      .stdout()
+      .command(['optimize', 'http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080'])
+      .it('works when url is passed with proxyHost and proxyPort with invalid host ', (ctx, done) => {
+        expect(ctx.stdout).to.contain('');
+        expect(ctx.stderr).to.equal('error loading AsyncAPI document from url: Failed to download http://localhost:8080/dummySpec.yml --proxyHost=host --proxyPort=8080.\n');
+        done();
+      });
   });
 
   describe('with no arguments', () => {