Resolved the spinner loading even after error in console

asyncapi · Dec 23, 2024 · 3d9be13 · 3d9be13
1 parent da64c63
commit 3d9be13
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/commands/generate/models.ts b/src/commands/generate/models.ts
@@ -56,19 +56,29 @@ export default class Models extends Command {
 
     const s = spinner();
     s.start('Generating models...');
-    const generatedModels = await generateModels({...flags, output}, document, logger, language as Languages);
-    if (output !== 'stdout') {
-      const generatedModelStrings = generatedModels.map((model) => { return model.modelName; });
-      s.stop(green(`Successfully generated the following models: ${generatedModelStrings.join(', ')}`));
-      return;
-    }
-    const generatedModelStrings = generatedModels.map((model) => {
-      return `
-## Model name: ${model.modelName}
-${model.result}
-      `;
-    });
-    s.stop(green(`Successfully generated the following models: ${generatedModelStrings.join('\n')}`));
+    try {
+      const generatedModels = await generateModels({...flags, output}, document, logger, language as Languages);
+      if (output !== 'stdout') {
+        const generatedModelStrings = generatedModels.map((model) => { return model.modelName; });
+        s.stop(green(`Successfully generated the following models: ${generatedModelStrings.join(', ')}`));
+        return;
+      }
+      const generatedModelStrings = generatedModels.map((model) => {
+        return `
+  ## Model name: ${model.modelName}
+  ${model.result}
+        `;
+      });
+      s.stop(green(`Successfully generated the following models: ${generatedModelStrings.join('\n')}`));
+    } catch (error) {
+      s.stop(green("Failed to generate models")); 
+
+      if (error instanceof Error) {
+        this.error(error.message);
+      } else {
+        this.error('An unknown error occurred during model generation.');
+      }
+    }    
   }
 
   private async parseArgs(args: Record<string, any>, output?: string) {