Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help validate Windows installer publishing #302

Closed
derberg opened this issue Jun 30, 2022 · 13 comments · Fixed by #524
Closed

Help validate Windows installer publishing #302

derberg opened this issue Jun 30, 2022 · 13 comments · Fixed by #524
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released

Comments

@derberg
Copy link
Member

derberg commented Jun 30, 2022

Reason/Context

This PR introduced automation for publishing of MacOS pkg file. It was also designed in the way that it should be easy to plug in generation of installer files for Windows and Linux.

This issue is for folks that work on Windows machine and can do some local testing to check if all works as expected

Description

@derberg derberg added the enhancement New feature or request label Jun 30, 2022
@derberg
Copy link
Member Author

derberg commented Jun 30, 2022

/help

@asyncapi-bot
Copy link
Contributor

Hello, @derberg! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

@derberg
Copy link
Member Author

derberg commented Jun 30, 2022

/gfi ci-cd

@asyncapi-bot asyncapi-bot added area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Jun 30, 2022
@Souvikns
Copy link
Member

@derberg for windows should we have a .msi installer or use some package manager like chocolatey?

@derberg
Copy link
Member Author

derberg commented Jul 26, 2022

@Souvikns for chocolatey we have this issue #304 as work is different than the one described here, and definitely not easy good first issue.

and yes, afaik, https://github.com/oclif/oclif#oclif-pack-win produces .msi but only Windows user can confirm.

I think we need both. Just like with my initial work on MacOS, I worked on brew and also pkg for those that do not use brew

@Souvikns
Copy link
Member

I tested it and it works, we just need to install p7zip and nsis to run the pack:windows command.

@Souvikns
Copy link
Member

I will just wait for #325 and then open a PR for this

@Souvikns
Copy link
Member

Souvikns commented Nov 9, 2022

@derberg I am getting this error while running npm run pack:win I am unable to find shasum for windows.

image

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 10, 2023
@derberg derberg removed the stale label Mar 14, 2023
@derberg
Copy link
Member Author

derberg commented Apr 18, 2023

@Souvikns hey man, since we use latest oclif, maybe you could give it another try?

@Souvikns
Copy link
Member

Will do 👍🏼

@Souvikns
Copy link
Member

@derberg now everything runs, and we get two .exe files, and it looks like it is the installer.

image

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants