Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows installer #524

Merged
merged 8 commits into from
Apr 25, 2023
Merged

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Apr 20, 2023

Description

This PR is adding windows installer to our generated assets in the release, pack:windows generates installer application for both x64 and x86 architechture windows.

  • asyncapi-v0.38.0-893aaaa-x64.exe renamed to asyncapi-x64.exe
  • asyncapi-v0.38.0-893aaaa-x86.exe renamed to asyncapi-x86.exe

Related issue(s)

Resolves #302

@Souvikns
Copy link
Member Author

@derberg, ready for review

@@ -29,6 +29,9 @@ npm install -g @asyncapi/cli
## Mac
There are two ways to install the AsyncAPI CLI on your macOS: using the `brew` package manager or `pkg` files.

### Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong location of section, Windows should not be under Mac

also please provide direct links to 64 and 32 bit files like we do for other distros -> https://github.com/asyncapi/cli/releases/latest/download/asyncapi.x64.pkg

these can be "predicted"

docs/installation.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns Souvikns requested a review from derberg April 25, 2023 12:09
@Souvikns
Copy link
Member Author

@derberg how do I test this, do I fork on a different account and try to create a release or something?

@derberg
Copy link
Member

derberg commented Apr 25, 2023

if you checked that files are really generated and that the pipeline is configured well, the links for sure work.

I think we are safe to assume it work, as long as above is confirmed

@Souvikns
Copy link
Member Author

if you checked that files are really generated and that the pipeline is configured well, the links for sure work.

I think we are safe to assume it work, as long as above is confirmed

I tested npm run pack:windows and releasePackagesRename.js script both are working as expected.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 🚀

@derberg
Copy link
Member

derberg commented Apr 25, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit aac6ce1 into asyncapi:master Apr 25, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Apr 25, 2023

@Souvikns I don't think the script worked as expected https://github.com/asyncapi/cli/actions/runs/4799227587/jobs/8538571267

@derberg
Copy link
Member

derberg commented Apr 25, 2023

built D:\a\cli\cli\dist\win32\asyncapi-v0.40.0-c3b0028-x86.exe
built D:\a\cli\cli\dist\win32\asyncapi-v0.40.0-c3b0028-x64.exe
🤔 Pattern 'dist/win32/asyncapi.x64.exe' does not match any files.
👩‍🏭 Creating new GitHub release for tag v$npm_package_version...
🤔 dist/win32/asyncapi.x64.exe not include valid file.

@derberg
Copy link
Member

derberg commented Apr 25, 2023

@Souvikns can you also manually attach windows files you have to https://github.com/asyncapi/cli/releases/tag/v0.40.0

@derberg
Copy link
Member

derberg commented Apr 25, 2023

@Souvikns last but not least, when you run npm run get-version --silent on windows, what do you get?

@Souvikns Souvikns deleted the windows-installer branch April 26, 2023 02:39
@Souvikns Souvikns restored the windows-installer branch April 26, 2023 02:39
@Souvikns
Copy link
Member Author

Souvikns commented Apr 26, 2023

@Souvikns last but not least, when you run npm run get-version --silent on windows, what do you get?

I think this does not work as intended
image

When I run the command on macos it gives me the version of the package.json, I think this is the problem, since it is behaving differently in windows, the rename script is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help validate Windows installer publishing
3 participants