-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add windows installer #524
Conversation
@derberg, ready for review |
docs/installation.md
Outdated
@@ -29,6 +29,9 @@ npm install -g @asyncapi/cli | |||
## Mac | |||
There are two ways to install the AsyncAPI CLI on your macOS: using the `brew` package manager or `pkg` files. | |||
|
|||
### Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong location of section, Windows should not be under Mac
also please provide direct links to 64 and 32 bit files like we do for other distros -> https://github.com/asyncapi/cli/releases/latest/download/asyncapi.x64.pkg
these can be "predicted"
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@derberg how do I test this, do I fork on a different account and try to create a release or something? |
if you checked that files are really generated and that the pipeline is configured well, the links for sure work. I think we are safe to assume it work, as long as above is confirmed |
I tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks 🚀
/rtm |
🎉 This PR is included in version 0.40.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@Souvikns I don't think the script worked as expected https://github.com/asyncapi/cli/actions/runs/4799227587/jobs/8538571267 |
|
@Souvikns can you also manually attach windows files you have to https://github.com/asyncapi/cli/releases/tag/v0.40.0 |
@Souvikns last but not least, when you run |
I think this does not work as intended When I run the command on macos it gives me the version of the package.json, I think this is the problem, since it is behaving differently in windows, the rename script is not working. |
Description
This PR is adding windows installer to our generated assets in the release,
pack:windows
generates installer application for bothx64
andx86
architechture windows.asyncapi-v0.38.0-893aaaa-x64.exe
renamed toasyncapi-x64.exe
asyncapi-v0.38.0-893aaaa-x86.exe
renamed toasyncapi-x86.exe
Related issue(s)
Resolves #302