fix: nullish examples #1033
fix: nullish examples #1033
Conversation
Signed-off-by: Shiva953 <[email protected]>
Shiva953
requested review from
Souvikns,
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
scripts/fetch-asyncapi-example.js
Outdated
| @@ -86,7 +86,7 @@ const buildCLIListFromExamples = async () => { | |||
| } | |||
| }); | |||
|
|
|||
| const exampleList = await Promise.all(buildExampleList); | |||
| const exampleList = (await Promise.all(buildExampleList)).filter(item => item!==null); | |||
There was a problem hiding this comment.
Nitpick:
| const exampleList = (await Promise.all(buildExampleList)).filter(item => item!==null); | |
| const exampleList = (await Promise.all(buildExampleList)).filter(item => item !== null); |
It seems we are not passing any linter to the scripts under scripts dir (I don't know the reason cc @Souvikns). Anyway this nitpick I suggest improves readability and needs to be considered.
|
@Shiva953 could you confirm you have tested this with an |
Signed-off-by: Shiva953 <[email protected]>
sure, here's the test(however, I also had to made the condition b8db1224d3e14ff69a591967fe891cb2.mp4 |
Co-authored-by: Sergio Moya <[email protected]>
Signed-off-by: Shiva953 <[email protected]>
Signed-off-by: Shiva953 <[email protected]>
|
We need a code owner to aprove the workflows to run, also to review this. cc @Souvikns @magicmatatjahu @derberg |
|
|
/rtm |
|
🎉 This PR is included in version 1.2.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
Resolves #994