Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added changeset configuration #1586

Merged
merged 6 commits into from
Dec 7, 2024

Conversation

akshatnema
Copy link
Member

Description

This PR targets adding a changeset configuration for cli and gitHub action for cli.

Related issue(s)

Shurtu-gal
Shurtu-gal previously approved these changes Dec 6, 2024
Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal
Copy link
Collaborator

@akshatnema before merging could you change the contibuting.md to add changeset to be added for releases

@Shurtu-gal Shurtu-gal self-requested a review December 6, 2024 20:58
Development.md Outdated

```markdown
---
"@asyncapi/generator": minor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to CLI as it could be easily confused?

Development.md Outdated

Before:
```json
"name": "@asyncapi/generator",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also

Development.md Outdated

After:
```json
"name": "@asyncapi/generator",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

Copy link

sonarqubecloud bot commented Dec 7, 2024

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit a9f1e12 into asyncapi:master Dec 7, 2024
23 checks passed
@Shurtu-gal
Copy link
Collaborator

@Souvikns FYI we are shifting to changeset style of releases now.

Discussion Thread: https://asyncapi.slack.com/archives/C07JW8SJK47

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot asyncapi-bot added released bounty AsyncAPI Bounty program related label labels Dec 7, 2024
@aeworxet
Copy link
Contributor

aeworxet commented Dec 9, 2024

@asyncapi/bounty_team

@akshatnema akshatnema deleted the add-changeset-config branch December 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label ready-to-merge released
Projects
Status: Completed
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants