-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add optimize command #397
feat: add optimize command #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please update readme
- please add different examples for command, like https://github.com/asyncapi/cli/pull/391/files#diff-4e67904b85de9b3b707b7ead9499c4ce0b38cebb1f0f9ee487782ac7293ff869R13
- also after checking out repo, installing and running build I get below. Not sure what I'm doing wrong, it should work otherwise how would you be able to play with it 🤔
src/commands/optimize.ts:2:21 - error TS2305: Module '"@asyncapi/optimizer"' has no exported member 'Output'.
2 import { Optimizer, Output, Report, ReportElement } from '@asyncapi/optimizer';
~~~~~~
src/commands/optimize.ts:2:29 - error TS2305: Module '"@asyncapi/optimizer"' has no exported member 'Report'.
2 import { Optimizer, Output, Report, ReportElement } from '@asyncapi/optimizer';
~~~~~~
src/commands/optimize.ts:2:37 - error TS2305: Module '"@asyncapi/optimizer"' has no exported member 'ReportElement'.
2 import { Optimizer, Output, Report, ReportElement } from '@asyncapi/optimizer';
~~~~~~~~~~~~~
src/commands/optimize.ts:50:11 - error TS2532: Object is possibly 'undefined'.
50 if (!(report.moveToComponents.length || report.removeComponents.length || report.reuseComponents.length)) {
~~~~~~~~~~~~~~~~~~~~~~~
src/commands/optimize.ts:50:45 - error TS2532: Object is possibly 'undefined'.
50 if (!(report.moveToComponents.length || report.removeComponents.length || report.reuseComponents.length)) {
~~~~~~~~~~~~~~~~~~~~~~~
src/commands/optimize.ts:50:79 - error TS2532: Object is possibly 'undefined'.
50 if (!(report.moveToComponents.length || report.removeComponents.length || report.reuseComponents.length)) {
~~~~~~~~~~~~~~~~~~~~~~
src/commands/optimize.ts:116:57 - error TS7006: Parameter 'e' implicitly has an 'any' type.
116 const totalMove = report.moveToComponents.filter((e) => e.action === 'move').length;
~
Found 7 errors in the same file, starting at: src/commands/optimize.ts:2
@derberg the tests are red all over this repo. As you can see in the commit history, I have bashed my head against the wall tooooo many times over these failing tests and achieved nothing. 😆 |
@KhudaDad414 please update to latest master, there are some conflicts |
@derberg I think it is ready. |
@KhudaDad414 relax, zen, and all that stuff..... conflicts again....so changes in docs in readme. You need to pull latest and move info about new command to respective markdown file in |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work and amazing patience 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
/rtm |
🎉 This PR is included in version 0.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
asyncapi optimize
command.Related issue(s)
Fixes #218 , to be merged after asyncapi/optimizer#129