feat: add chocolatey support #847
Conversation
Shurtu-gal
requested review from
Souvikns,
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
|
TODO :-
|
There was a problem hiding this comment.
@derberg If you would be testing it somewhere please use id such as asyncapi-test-123466 instead of asyncapi
At these places :-
| cd ./deploy/chocolatey | ||
| choco pack ./asyncapi-cli.nuspec | ||
| choco apikey add --source "'https://push.chocolatey.org/'" --key ${{ secrets.CHOCOLATEY_API_KEY }} | ||
| choco push ./asyncapi.${{ steps.release_version.outputs.version }}.nupkg --source "'https://push.chocolatey.org/'" |
There was a problem hiding this comment.
please also add failure handling so we know if deploy to chocolatey fails -> https://github.com/asyncapi/cli/blob/master/.github/workflows/bump-homebrew-formula.yml#L32
| <!-- Do not remove this test for UTF-8: if “Ω” doesn’t appear as greek uppercase omega letter enclosed in quotation marks, you should use an editor that supports UTF-8, not this one. --> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd"> | ||
| <metadata> | ||
| <id>asyncapi</id> |
| cd ./deploy/chocolatey | ||
| choco pack ./asyncapi-cli.nuspec | ||
| choco apikey add --source "'https://push.chocolatey.org/'" --key ${{ secrets.CHOCOLATEY_API_KEY }} | ||
| choco push ./asyncapi.${{ steps.release_version.outputs.version }}.nupkg --source "'https://push.chocolatey.org/'" |
There was a problem hiding this comment.
please also add failure handling so we know if deploy to chocolatey fails -> https://github.com/asyncapi/cli/blob/master/.github/workflows/bump-homebrew-formula.yml#L32
* put deploy folder in .github/workflows
|
All required changes are done @derberg. |
Yeah, forgot to see it in the above-most one. Updated the installation docs just now. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 0.60.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
#599
#304