-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update @asyncapi/generator to 1.15.0 version #908
Conversation
…i/generator-1.15.0
The tests failed for two specific commands The describe('git clash', () => {
const pathToOutput = './test/docs/2';
before(() => {
fs.mkdirSync(pathToOutput, { recursive: true });
// Write a random file to trigger that dir has unstaged changes.
fs.writeFileSync(path.join(pathToOutput, 'random.md'), '');
});
test
.stderr()
.command([...generalOptions, '--output=./test/docs/2'])
.it(
'should throw error if output folder is in a git repository',
(ctx, done) => {
expect(ctx.stderr).to.contain(
'Error: "./test/docs/2" is in a git repository with unstaged changes.'
);
cleanup('./test/docs/2');
done();
}
);
}); The |
@@ -35,7 +35,6 @@ operations: | |||
components: | |||
messages: | |||
UserSignedUp: | |||
messageId: UserSignedUp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the messageId
! good catch
@Souvikns looking the same direction you figured about messageId, maybe the same is the reason of issue in generator test -> https://github.com/asyncapi/cli/blob/master/test/fixtures/specification-v3.yml#L99 ? and maybe generator do not throw errors because of asyncapi/parser-js#878? |
This actually fixed it in my local computer lets see why having an issue in gh action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg I tried a lot but was unable to find why we were still getting this error, I have skipped the test, We can merge this if we want and will create a new issue for solving this later. I will try to solve this when I come back from AACOT23 Bangalore. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we can merge
I found the missing bug -> asyncapi/generator#1076
so we merge your PR, and I will monitor automation, once asyncapi/generator#1076 gets merged and in CLI 1.15.1 bump PR will show up, I will make sure to enable the test that we skip
/rtm |
🎉 This PR is included in version 1.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.