Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @asyncapi/generator to 1.15.0 version #908

Merged
merged 16 commits into from
Nov 29, 2023

Conversation

asyncapi-bot
Copy link
Contributor

No description provided.

@Souvikns
Copy link
Member

The tests failed for two specific commands validate and generate fromTemplate.

The validate command was having issues because the spec used to run the tests had an issue that I fixed.

  describe('git clash', () => {
    const pathToOutput = './test/docs/2';
    before(() => {
      fs.mkdirSync(pathToOutput, { recursive: true });
      // Write a random file to trigger that dir has unstaged changes.
      fs.writeFileSync(path.join(pathToOutput, 'random.md'), '');
    });
    test
      .stderr()
      .command([...generalOptions, '--output=./test/docs/2'])
      .it(
        'should throw error if output folder is in a git repository',
        (ctx, done) => {
          expect(ctx.stderr).to.contain(
            'Error: "./test/docs/2" is in a git repository with unstaged changes.'
          );
          cleanup('./test/docs/2');
          done();
        }
      );
  });

The generate fromTemplate is failing because' Generation is in progress. Keep calm` is getting printed in error, still trying to solve this

@@ -35,7 +35,6 @@ operations:
components:
messages:
UserSignedUp:
messageId: UserSignedUp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, the messageId ! good catch

@derberg
Copy link
Member

derberg commented Nov 22, 2023

@Souvikns looking the same direction you figured about messageId, maybe the same is the reason of issue in generator test -> https://github.com/asyncapi/cli/blob/master/test/fixtures/specification-v3.yml#L99 ?

and maybe generator do not throw errors because of asyncapi/parser-js#878?

@Souvikns
Copy link
Member

This actually fixed it in my local computer lets see why having an issue in gh action.

@jonaslagoni
Copy link
Member

Any update here 🤔? @Souvikns @derberg

@derberg derberg self-requested a review November 28, 2023 19:44
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Souvikns any updates, I see you did many changes to test in 8461e96

@Souvikns
Copy link
Member

@Souvikns any updates, I see you did many changes to test in 8461e96

@derberg I tried a lot but was unable to find why we were still getting this error, I have skipped the test, We can merge this if we want and will create a new issue for solving this later. I will try to solve this when I come back from AACOT23 Bangalore.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can merge

I found the missing bug -> asyncapi/generator#1076

so we merge your PR, and I will monitor automation, once asyncapi/generator#1076 gets merged and in CLI 1.15.1 bump PR will show up, I will make sure to enable the test that we skip

@derberg
Copy link
Member

derberg commented Nov 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit e200f13 into master Nov 29, 2023
11 checks passed
@asyncapi-bot asyncapi-bot deleted the bot/bump-@asyncapi/generator-1.15.0 branch November 29, 2023 11:30
@asyncapi-bot
Copy link
Contributor Author

🎉 This PR is included in version 1.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants