-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: completed the conversion from postman to asyncapi #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Have completed the conversion from postman-collection to asyncapi, please review it whenever you can cc @jonaslagoni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
Few things are needed:
- Add a section in the main README.md about this new feature
- Add a new test that uses the newly added option
- Fix the CI problems
Also make sure that the perspective options are passed to the OpenAPI converter function. |
Hey @jonaslagoni completed the work that you have pointed out, review will be appreciated |
Nicely Done @ItshMoh |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @ItshMoh 🔥
@all-contributors please add @ItshMoh for code, test, docs, example |
I've put up a pull request to add @ItshMoh! 🎉 |
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
converter now can convert postman collection to asyncapi
Related issue(s)
Fixes #234