Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: completed the conversion from postman to asyncapi #276

Merged
merged 12 commits into from
Sep 8, 2024

Conversation

ItshMoh
Copy link
Contributor

@ItshMoh ItshMoh commented Sep 5, 2024

Description
converter now can convert postman collection to asyncapi

Related issue(s)
Fixes #234

converter

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ItshMoh
Copy link
Contributor Author

ItshMoh commented Sep 5, 2024

Have completed the conversion from postman-collection to asyncapi, please review it whenever you can

cc @jonaslagoni

src/interfaces.ts Outdated Show resolved Hide resolved
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

Few things are needed:

  • Add a section in the main README.md about this new feature
  • Add a new test that uses the newly added option
  • Fix the CI problems

@jonaslagoni
Copy link
Member

Also make sure that the perspective options are passed to the OpenAPI converter function.

@ItshMoh ItshMoh requested a review from jonaslagoni September 7, 2024 19:54
@ItshMoh
Copy link
Contributor Author

ItshMoh commented Sep 7, 2024

Add a section in the main README.md about this new feature
Add a new test that uses the newly added option
Fix the CI problems

Hey @jonaslagoni completed the work that you have pointed out, review will be appreciated

@Gmin2
Copy link
Contributor

Gmin2 commented Sep 7, 2024

Nicely Done @ItshMoh

Copy link

sonarqubecloud bot commented Sep 7, 2024

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @ItshMoh 🔥

@jonaslagoni jonaslagoni merged commit 92cfd9a into asyncapi:master Sep 8, 2024
9 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @ItshMoh for code, test, docs, example

Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @ItshMoh! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert from Postman Collection 2.1 to AsyncAPI 3.0
4 participants